[SERVER-47074] Clean up log lines in mongo/client/sdam and RSM-related files Created: 24/Mar/20  Updated: 29/Oct/23  Resolved: 12/May/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.0-rc7, 4.7.0

Type: Task Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Haley Connelly
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
is duplicated by SERVER-47739 Log message references nonexistent at... Closed
Related
related to SERVER-47921 Lint log lines in src/mongo/client Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Service Arch 2020-04-06, Service arch 2020-04-20, Service arch 2020-05-04, Service arch 2020-05-18
Participants:

 Description   

When we switched to logv2, our log lines were converted via perl script. Let's go through and make them more readable and parseable. The following files might need attention:

Show all

src/mongo/client/remote_command_retry_scheduler_test.cpp
src/mongo/client/remote_command_targeter_rs.cpp
src/mongo/client/replica_set_change_notifier.cpp
src/mongo/client/replica_set_monitor_manager.cpp
src/mongo/client/scanning_replica_set_monitor_scan_test.cpp
src/mongo/client/scanning_replica_set_monitor_test_concurrent.cpp
src/mongo/client/scanning_replica_set_monitor.cpp
src/mongo/client/sdam/sdam_json_test_runner.cpp
src/mongo/client/sdam/server_description.cpp
src/mongo/client/sdam/server_selector.cpp
src/mongo/client/sdam/topology_description.cpp
src/mongo/client/sdam/topology_manager.cpp
src/mongo/client/sdam/topology_state_machine.cpp
src/mongo/client/server_is_master_monitor.cpp
src/mongo/client/server_ping_monitor_test.cpp
src/mongo/client/server_ping_monitor.cpp
src/mongo/client/streamable_replica_set_monitor_query_processor.cpp
src/mongo/client/streamable_replica_set_monitor.cpp



 Comments   
Comment by Githook User [ 14/May/20 ]

Author:

{'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}

Message: SERVER-47074 Clean up log lines in mongo/client/sdam and RSM-related files

(cherry picked from commit 694b92620fe581f57ed78ca9c4c59ece4d5b9a74)
Branch: v4.4
https://github.com/mongodb/mongo/commit/a1a0f08128baa0c625c45d4e16122a4f0badd400

Comment by Githook User [ 12/May/20 ]

Author:

{'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}

Message: SERVER-47074 Clean up log lines in mongo/client/sdam and RSM-related files
Branch: master
https://github.com/mongodb/mongo/commit/694b92620fe581f57ed78ca9c4c59ece4d5b9a74

Comment by Haley Connelly [ 06/May/20 ]

Done. Thanks for catching that!

Comment by Bruce Lucas (Inactive) [ 06/May/20 ]

I noticed that 4333218 in server_is_master_monitor.cpp has a "duration" attr, but this is not reporting the completion of an operation so shouldn't be "duration". Can you fix that with this ticket? Suggest maybe "delay".

Generated at Thu Feb 08 05:13:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.