[SERVER-47110] The --separate-debug flag doesn't work with Ninja Created: 25/Mar/20  Updated: 29/Oct/23  Resolved: 27/Apr/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.4.0-rc4, 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-47776 Promote ninja-next to stable Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Dev Platform 2020-04-20, Dev Platform 2020-05-04
Participants:

 Description   

Looks like Hygienic builds do not work with Ninja on Windows:

D:\workspace\mongodb-master>buildscripts\scons.py --jlink=4 --install-mode=hygienic --ssl --win-version-min=win10 --detect-odr-violations --dbg=on --opt=off CPPPATH="D:/workspace/libs/snmp/include D:/workspace/libs/sasl/include" LIBPATH="D:/workspace/libs/snmp/lib D:/workspace/libs/sasl/lib" MONGO_GIT_HASH="unknown" MONGO_VERSION="0.0.0" VARIANT_DIR=ninja --ninja build.ninja
...
D:\workspace\mongodb-master>ninja install-core
ninja: error: build.ninja:11328: multiple rules generate build/ninja/mongo/mongotrafficreader.pdb [-w dupbuild=err]

Hygienic builds without Ninja seem to work though:

D:\workspace\mongodb-master>buildscripts\scons.py --jlink=4 --install-mode=hygienic --ssl --win-version-min=win10 --detect-odr-violations --dbg=on --opt=off CPPPATH="D:/workspace/libs/snmp/include D:/workspace/libs/sasl/include" LIBPATH="D:/workspace/libs/snmp/lib D:/workspace/libs/sasl/lib" install-core



 Comments   
Comment by Githook User [ 29/Apr/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-47110 Don't emit the PDB file twice when separate debug is enabled

(cherry picked from commit 4ccd6ac3af74339c9fc1576875ce2377edbee1f2)
Branch: v4.4
https://github.com/mongodb/mongo/commit/b6490b1e36d367706adf26513db350c6f398d98c

Comment by Githook User [ 27/Apr/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-47110 Don't emit the PDB file twice when separate debug is enabled
Branch: master
https://github.com/mongodb/mongo/commit/4ccd6ac3af74339c9fc1576875ce2377edbee1f2

Generated at Thu Feb 08 05:13:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.