[SERVER-47195] Allow failCommand failpoint to trigger only on a specific MongoClient Created: 30/Mar/20 Updated: 08/Jan/24 Resolved: 07/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc2, 4.2.9, 4.7.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Shane Harvey | Assignee: | Spencer Brody (Inactive) |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v4.4, v4.2
|
||||||||||||
| Sprint: | Service arch 2020-04-20 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
For streamable isMaster, drivers would like to add tests that fail isMaster commands, like this:
And:
However, failing isMaster with failCommand is tricky because:
It would be great if the failCommand failpoint was able to filter which clients trigger the failure. One proposal to fix these issues would be to implement an "appName" filter on the failCommand failpoint. "appName" would work similar to the "threadName" (
|
| Comments |
| Comment by Githook User [ 17/Jun/20 ] |
|
Author: {'name': 'Spencer T Brody', 'email': 'spencer@10gen.com', 'username': 'stbrody'}Message: (cherry picked from commit 2b742ad3d0fbf0238c32e6cd3b5842fb5bee77b9) |
| Comment by Spencer Brody (Inactive) [ 12/May/20 ] |
|
Requesting backport to 4.2 |
| Comment by Jeffrey Yemin [ 12/May/20 ] |
|
spencer any change for a 4.2 backport of this failpoint improvement? It would really help us to add pre-streamable ismaster integration tests in drivers if we had this is 4.2. CC shane.harvey |
| Comment by Githook User [ 13/Apr/20 ] |
|
Author: {'name': 'Spencer T Brody', 'email': 'spencer@10gen.com', 'username': 'stbrody'}Message: (cherry picked from commit 021db11a119f431d25afef650735cbf61a823a40) |
| Comment by Githook User [ 07/Apr/20 ] |
|
Author: {'name': 'Spencer T Brody', 'email': 'spencer@10gen.com', 'username': 'stbrody'}Message: |