[SERVER-47205] Stopping dropping snapshots after safe reconfig that does not change writeConcernMajorityJournalDefault Created: 31/Mar/20 Updated: 01/Dec/23 Resolved: 17/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc3, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Tess Avitabile (Inactive) | Assignee: | Siyuan Zhou |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | former-quick-wins | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||||||||||||||
| Sprint: | Repl 2020-05-04 | ||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||
| Description |
|
After a reconfig, we drop snapshots, since the definition of majority-committed can change. However, all this does is set _currentCommittedSnapshot to none. It does not change the The safe reconfig protocol guarantees that operations committed in the old config will never roll back, so we can stop dropping snapshots after a safe reconfig that does not change writeConcernMajorityJournalDefault. |
| Comments |
| Comment by Githook User [ 24/Apr/20 ] |
|
Author: {'name': 'Siyuan Zhou', 'email': 'siyuan.zhou@mongodb.com', 'username': 'visualzhou'}Message: (cherry picked from commit a397fc442440984fca2ab37f491759745979ab2d) |
| Comment by Siyuan Zhou [ 17/Apr/20 ] |
|
The backport of this ticket is necessary for |
| Comment by Githook User [ 17/Apr/20 ] |
|
Author: {'name': 'Siyuan Zhou', 'email': 'siyuan.zhou@mongodb.com', 'username': 'visualzhou'}Message: |