[SERVER-47258] Refactor the WiredTigerOplogManager Created: 01/Apr/20  Updated: 29/Oct/23  Resolved: 08/Apr/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.4.0-rc8, 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Dianna Hohensee (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Problem/Incident
causes SERVER-48240 Undo unintentional functional change ... Closed
Related
related to SERVER-45810 Explore removing the WiredTigerOplogM... Closed
is related to SERVER-45025 Remove WiredTigerOplogManager thread Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Execution Team 2020-04-06, Execution Team 2020-04-20
Participants:
Linked BF Score: 0

 Description   

Remove the small delay to update the oplogReadTimestamp when there are no callers (waitForAllEarlierOplogWritesToBeVisible) awaiting updates to the oplogReadTimestamp. This code is extra logic added in order not to overwhelm the system with too frequent I/O when the thread used to call waitUntilDurable() (flush to disk). The waiting logic was added in this commit in v3.6, to handle the waitUntilDurable() call also added in v3.6. There is no longer a waitUntilDurable() call in the code since the Replicate Before Journaling project completed.

We also need to rename the functions, etc., to better reflect that journal flushing no longer happens.

UPDATE:

This is going to be a purely non-functional change now. The performance results were not good removing the delay. See the CR for details.



 Comments   
Comment by Dianna Hohensee (Inactive) [ 29/May/20 ]

Author:

{'name': 'Dianna Hohensee', 'email': 'dianna.hohensee@mongodb.com', 'username': 'DiannaHohensee'}

Message: SERVER-47258 Refactor the WiredTigerOplogManager: improve names, comments, logs.

(cherry picked from commit aa30f3747a32237e5dbb187c5bedd19108ad2f4e)

SERVER-48240 Undo accidental functional change to WiredTigerOplogManager that causes a performance degradation

(cherry picked from commit 26cff8f010cac091c17d7373f8ead0e8c73ee6f7)
Branch: v4.4
https://github.com/mongodb/mongo/commit/7d075fc7fddfadaff15e4f98fd8ded80b0035fec

Comment by Githook User [ 08/Apr/20 ]

Author:

{'name': 'Dianna Hohensee', 'email': 'dianna.hohensee@mongodb.com', 'username': 'DiannaHohensee'}

Message: SERVER-47258 Refactor the WiredTigerOplogManager: improve names, comments, logs.
Branch: master
https://github.com/mongodb/mongo/commit/aa30f3747a32237e5dbb187c5bedd19108ad2f4e

Generated at Thu Feb 08 05:13:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.