[SERVER-47266] Remove "New session started with sessionID" test messages Created: 02/Apr/20  Updated: 29/Oct/23  Resolved: 03/Apr/20

Status: Closed
Project: Core Server
Component/s: JavaScript
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Minor - P4
Reporter: A. Jesse Jiryu Davis Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Repl 2020-04-06
Participants:
Linked BF Score: 0

 Description   

I think that the prominent "New session started with sessionID" messages that the shell logs during tests are no longer useful, now that logical sessions have been in production for a couple releases. I propose removing them altogether. Or, if there are some tests where these messages are still useful, let's restrict the messages to those tests.



 Comments   
Comment by A. Jesse Jiryu Davis [ 03/Apr/20 ]

Not requesting backport, this is not a major problem when debugging build failures in 4.4 and older.

Comment by Githook User [ 03/Apr/20 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: SERVER-47266 Terser "new session" logs from shell
Branch: master
https://github.com/mongodb/mongo/commit/d6a90860085a907e739d1dcfdc56887eca7bb715

Comment by A. Jesse Jiryu Davis [ 02/Apr/20 ]

OK, I concur with using print.

Comment by Maria van Keulen [ 02/Apr/20 ]

judah.schvimer Will's suggestion makes sense. I think these lines can still be useful in certain circumstances.

Comment by Judah Schvimer [ 02/Apr/20 ]

I have definitely used them in the past, but not recently. I suggest we start with Will's suggestion and we can always remove them if they're still a bother. maria.vankeulen, since you worked on transactions most recently, do you have an opinion here?

Comment by A. Jesse Jiryu Davis [ 02/Apr/20 ]

Have we used these messages for BF diagnosis in recent memory? If not, let's really remove them, otherwise Will's suggestion SGTM.

Comment by Judah Schvimer [ 02/Apr/20 ]

I vote for william.schultz's suggestion. I think they're still useful for tracking the lifetime of a session, but having them easily ignorable would I think address the pain. jesse, does that work for you?

Comment by William Schultz (Inactive) [ 02/Apr/20 ]

I agree that these are kind of annoying to see in the logs and they take up a lot of vertical space. If we wanted to keep them, one alternative would be to use print instead of jsTest.log so that they only take up one log line.

Generated at Thu Feb 08 05:13:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.