[SERVER-47324] Skip dassert when index commands from non internal clients abort migrations Created: 03/Apr/20  Updated: 29/Oct/23  Resolved: 14/Apr/20

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Jack Mulrow Assignee: Gregory Noma
Resolution: Fixed Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-48089 Blacklist move_chunk_critical_section... Closed
is related to SERVER-45017 [correct indexes] Remove index comman... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2020-04-20
Participants:
Linked BF Score: 21

 Description   

PM-1361 changed the protocol for index modifying commands on sharded collections to require shard versions and for the execution of these commands to be mutually exclusive with the migration critical section. To verify this, a dassert was added that there is not an active critical section when the corresponding opObserver method for each index command is run. This dassert is not valid for index commands run directly against a shard, because they will not contain a shard version. Some of our testing hooks, like checkReplDBHash, use a ReplSetTest method that runs noop collMods on every non-system collection to wait for background index activity to complete, which can trigger the dassert.

Restricting the dassert to only apply to commands sent on an internal connection (i.e. from a mongod or mongos) should avoid these failures while allowing it to serve its intended purpose.



 Comments   
Comment by Githook User [ 14/Apr/20 ]

Author:

{'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}

Message: SERVER-47324 Skip dassert when index commands from non-internal clients abort migrations
Branch: master
https://github.com/mongodb/mongo/commit/091c38c8b87d3276dd8b13e7425693493ea29cea

Generated at Thu Feb 08 05:13:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.