[SERVER-47390] Improve styling of Replication log lines Created: 07/Apr/20  Updated: 29/Oct/23  Resolved: 01/May/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.4.0-rc4, 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Jason Chan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File 20_04_02_02_05_48.txt    
Issue Links:
Backports
Related
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Repl 2020-05-04
Participants:

 Description   

The log lines in topology_version_observer.cpp were not addressed inĀ SERVER-46389.



 Comments   
Comment by Githook User [ 05/May/20 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@10gen.com', 'username': 'jasonjhchan'}

Message: SERVER-47390 Improve styling of Replication log lines

(cherry picked from commit c28d271102bcf3484c56ad592065ddae9c73ee5d)
Branch: v4.4
https://github.com/mongodb/mongo/commit/8602f5f7b69d2ae71ed7a50acfc779ac57eba107

Comment by Jason Chan [ 04/May/20 ]

Filed SERVER-47946 to address the rate of the logs

Comment by William Schultz (Inactive) [ 04/May/20 ]

jason.chan Even after the latest commits from this ticket, when the log level for replication component is >=1, these messages are extremely frequent (every millisecond?) i.e.

[js_test:quorum_check] 2020-05-04T17:31:32.967-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.967-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.967-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.967-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.967-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.967-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.967-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.788-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.968-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.789-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.969-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.981-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}
[js_test:quorum_check] 2020-05-04T17:31:32.981-0400 d36032| 2020-05-04T17:31:32.790-04:00 D1 REPL     [TopologyVersionObserver] Observer was interrupted by an exception{"error":"ShutdownInProgress: The server is in quiesce mode and will shut down"}

Even at a high log verbosity level, it doesn't seem we need to printing these messages so often.

Comment by Githook User [ 01/May/20 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@10gen.com', 'username': 'jasonjhchan'}

Message: SERVER-47390 Improve styling of Replication log lines
Branch: master
https://github.com/mongodb/mongo/commit/c28d271102bcf3484c56ad592065ddae9c73ee5d

Comment by Githook User [ 30/Apr/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: Revert "SERVER-47390 Improve styling of Replication log lines"

This reverts commit 2706275d9a44ef89e48b26d2245cd893bee094d6.
Branch: master
https://github.com/mongodb/mongo/commit/b89a546076135f2d6692111ea25a224355cdbd0e

Comment by Githook User [ 29/Apr/20 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@10gen.com', 'username': 'jasonjhchan'}

Message: SERVER-47390 Improve styling of Replication log lines
Branch: master
https://github.com/mongodb/mongo/commit/2706275d9a44ef89e48b26d2245cd893bee094d6

Comment by Jason Chan [ 27/Apr/20 ]

bruce.lucas I can take a look at the log lines you mentioned as part of this ticket. Thanks for letting us know!

Comment by Bruce Lucas (Inactive) [ 27/Apr/20 ]

Thanks Tess. I can't swear to the accuracy or currency of this, but I think there may also be a couple stragglers in a couple of other files. Would it be possible to check these too you're at it?

id 23722 in src/mongo/db/repl/check_quorum_for_config_change.cpp
id 23726 in src/mongo/db/repl/check_quorum_for_config_change.cpp

Comment by Tess Avitabile (Inactive) [ 07/Apr/20 ]

We can also consider cleaning up any of the REPL log lines in the attached file. Log lines for failpoints do not need to be addressed.

Generated at Thu Feb 08 05:14:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.