[SERVER-47691] ReplSetTest should be resilient to unmet external dependencies Created: 21/Apr/20  Updated: 29/Oct/23  Resolved: 12/May/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.4.0-rc6, 4.7.0

Type: Bug Priority: Major - P3
Reporter: William Schultz (Inactive) Assignee: William Schultz (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by TOOLS-2554 Remove ReplSetTest file dependencies ... Closed
Related
related to SERVER-43766 Investigate the slowest sections of R... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Repl 2020-05-18
Participants:

 Description   

ReplSetTest should be usable from within the shell outside of a mongo source repo. Currently, replsettest.js has a few dependencies on files that are not built into the shell, so loading them may fail if the mongo shell binary is run outside of a mongo source repo. We should either remove these dependencies or make ReplSetTest work around the cases when these dependencies are absent.



 Comments   
Comment by Githook User [ 12/May/20 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-47691 Remove reliance on external dependencies in ReplSetTest

(cherry picked from commit be4fd3cca7fc4ea6883ceb1e262b0ac5cc7ecf69)
Branch: v4.4
https://github.com/mongodb/mongo/commit/1c9a43aa1e3801f09b2323d9290b60a37056269e

Comment by Githook User [ 12/May/20 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-47691 Add missing explicit JS dependencies for tests that use ReplSetTest

(cherry picked from commit f836e3ce66cc0051a468892763d61018004df4b0)
Branch: v4.4
https://github.com/mongodb/mongo/commit/bc2892576ac1893706bdd170daa8a02842bb355f

Comment by Githook User [ 12/May/20 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-47691 Remove reliance on external dependencies in ReplSetTest
Branch: master
https://github.com/mongodb/mongo/commit/be4fd3cca7fc4ea6883ceb1e262b0ac5cc7ecf69

Comment by Githook User [ 08/May/20 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-47691 Add missing explicit JS dependencies for tests that use ReplSetTest
Branch: master
https://github.com/mongodb/mongo/commit/f836e3ce66cc0051a468892763d61018004df4b0

Comment by William Schultz (Inactive) [ 21/Apr/20 ]

To fix this, we can consider removing the dependencies on fail_point_util.js and rslib.js by just calling the configureFailPoint command directly instead of using the failpoint helpers. For the parallelTester.js dependency, we can consider dynamically checking for its existence and if it's not available, just do collection validation here serially instead of in parallel using Thread objects.

Generated at Thu Feb 08 05:14:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.