[SERVER-47739] Log message references nonexistent attribute Created: 23/Apr/20  Updated: 06/Dec/22  Resolved: 24/Apr/20

Status: Closed
Project: Core Server
Component/s: Diagnostics
Affects Version/s: 4.3.6
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Oleg Pudeyev (Inactive) Assignee: Backlog - Service Architecture
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-47074 Clean up log lines in mongo/client/sd... Closed
Related
is related to SERVER-47073 Clean up log lines in mongo/client an... Closed
Assigned Teams:
Service Arch
Operating System: ALL
Participants:

 Description   

I have this log entry in my logs:

RSM {setName} rescheduling next isMaster check for {host} in {delay} {'host': 'localhost:14421', 'delayMillis': 0, 'setName': 'ruby-driver-rs'}

Should delay and delayMillis be called the same?



 Comments   
Comment by Oleg Pudeyev (Inactive) [ 24/Apr/20 ]

Thank you for the response, could I have an answer to this question as well:

> Is there a ticket I can track for when all of the references in the logs are supposed to be valid?

Or, to adjust it for the provided information, what is a tracking ticket for converting all of the log messages to not have substution strings.

https://jira.mongodb.org/browse/SERVER-47073 does not appear to be linked to an epic.

Comment by Bruce Lucas (Inactive) [ 24/Apr/20 ]

Ah, thanks! I'll close this ticket as a dup then.

Comment by Benjamin Caimano (Inactive) [ 24/Apr/20 ]

bruce.lucas, I had touched these files for SERVER-47073 to make sure "setName" became "replicaSet" but didn't do much more. There is actually already a ticket, SERVER-47074, to update these files.

Comment by Bruce Lucas (Inactive) [ 24/Apr/20 ]

oleg.pudeyev, we're actually in the process of removing the substitution strings (i.e. references) from all log messages.

ben.caimano, it looks like this log message is coming from server_is_master_monitor.cpp. This particular message I think was cleaned up in master, but it looks like there are other messages in that file that we missed. A survey I made of logs generated in Evergreen by our tests seems to indicate that there are still problematic messages coming from these files. I wonder if we could use this ticket to take another look at these files?

src/mongo/client/replica_set_monitor_manager.cpp
src/mongo/client/scanning_replica_set_monitor.cpp
src/mongo/client/sdam/topology_manager.cpp
src/mongo/client/sdam/topology_state_machine.cpp
src/mongo/client/server_is_master_monitor.cpp
src/mongo/client/server_ping_monitor.cpp
src/mongo/client/streamable_replica_set_monitor.cpp

Comment by Oleg Pudeyev (Inactive) [ 23/Apr/20 ]

I was going to go through all of the server logs produced in evergreen from my driver tests and report any broken references, it sounds like I shouldn't be doing that? Is there a ticket I can track for when all of the references in the logs are supposed to be valid?

Comment by Bruce Lucas (Inactive) [ 23/Apr/20 ]

Actually this message and afaics all the other messages in that file have yet to be completely converted over to logv2 format by removing the substitution strings from the msg, i.e. the msg string shouldn't have

{delay}

at all.

Generated at Thu Feb 08 05:15:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.