[SERVER-47747] Improve ordering of ninja and hygienic tools in SConstruct Created: 24/Apr/20 Updated: 18/Aug/20 Resolved: 30/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||
| Sprint: | Dev Platform 2020-05-04 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
The ninja and hygienic tools manipulate emitter lists, as do other tools. However, both of them must be, in some sense, the last tool. Additionally, both tools should run before any other non-conftest targets are declared. The current ordering of the SConstruct makes it perhaps too easy to break these constraints, and there are several other odd ordering choices as well. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 30/Apr/20 ] |
|
I've changed my mind on this. It will just make it harder to backport build system fixes across the various branches, which is looking increasingly important during the ninja generator and hygienic build transitions. We can revisit once that has stablized. |