[SERVER-47769] Ensure that gather_failed_unittests does not target .cpp files Created: 24/Apr/20  Updated: 29/Oct/23  Resolved: 09/Jun/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.0-rc9

Type: Bug Priority: Major - P3
Reporter: Raiden Worley (Inactive) Assignee: Richard Samuels (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: STM 2020-06-15
Participants:
Linked BF Score: 55
Story Points: 1

 Description   

This find command is capable of targeting source files, if ${exe} expands to the empty string (as it does on non-Windows).

We should add an operator that checks whether the file type is an executable.



 Comments   
Comment by Githook User [ 09/Jun/20 ]

Author:

{'name': 'Richard Samuels', 'email': 'richard.samuels@mongodb.com', 'username': 'richardsamuels'}

Message: SERVER-47769 Ensure that gather_failed_unittests does not target .cpp files

(cherry picked from commit c511c2951b30ac612a57c3639fb3760f24a8389c)
Branch: v4.4
https://github.com/mongodb/mongo/commit/6401aad2b957679cc70b8e3de048fd0c6869db8a

Comment by Richard Samuels (Inactive) [ 09/Jun/20 ]

Adding a quick note that a $ would not have solved this issue, so we settled on using GNU find's -executable flag.

Comment by Githook User [ 09/Jun/20 ]

Author:

{'name': 'Richard Samuels', 'email': 'richard.samuels@mongodb.com', 'username': 'richardsamuels'}

Message: SERVER-47769 Ensure that gather_failed_unittests does not target .cpp files
Branch: master
https://github.com/mongodb/mongo/commit/c511c2951b30ac612a57c3639fb3760f24a8389c

Comment by Richard Samuels (Inactive) [ 04/Jun/20 ]

CR: https://mongodbcr.appspot.com/620280138/

Comment by Brooke Miller [ 19/May/20 ]

Aligned on adding a $ to solve this.

Generated at Thu Feb 08 05:15:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.