[SERVER-47796] commit-queue lint-clang-format not run on enterprise changes Created: 27/Apr/20 Updated: 29/Oct/23 Resolved: 06/May/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc4, 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | David Bradford (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v4.4
|
||||||||
| Sprint: | DAG 2020-05-04, DAG 2020-05-18 | ||||||||
| Participants: | |||||||||
| Story Points: | 2 | ||||||||
| Description |
|
I have the same issue as https://jira.mongodb.org/browse/EVG-7894 It looks to me like maybe the commit-queue CI might not include Enterprise module changes in the lint-clang-format task, the way that the master waterfall CI does. I submitted a change that got through with format errors in enterprise code, only to break the master waterfall and generate a BFG. https://jira.mongodb.org/browse/BFG-599619 My commit-queue CI run's lint-clang-format task doesn't look like it made a patch from the enterprise module change. |
| Comments |
| Comment by Githook User [ 06/May/20 ] |
|
Author: {'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}Message: (cherry picked from commit 74ea6aa4dfd7b3b4acf090084d36891834a49385) |
| Comment by Githook User [ 06/May/20 ] |
|
Author: {'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}Message: |
| Comment by Billy Donahue [ 27/Apr/20 ] |
|
(I had already written this up as an EVG ticket EVG-7894). I just submitted via commit-queue a change that had mongo and enterprise components. This is The first enterprise change I submitted wasn't updated with my clang-format run by mistake, so it broke the clang-format linter (@ 2020-04-26T23:07:10Z). generating BFG-599619 ticket (@ 2020-04-26T23:15:06) which I fixed immediately with a follow-on change via commit-queue (@ 2020-04-27T00:18:54Z). As of this writing (@ 2020-04-27T05:13:00Z), the master waterfall still hasn't been updated to show this fix. It looks like enterprise changes, even via commit queue, don't cause a CI run. The bigger problem is that the commit queue let this in. I see that the commit-queue runs a lint_clang_format task, but my commit-queue tasks all passed even though the enterprise component wasn't clang-format-compliant. So the commit-queue CI run doesn't check for errors in the enterprise module the way the waterfall CI run does. They should logically be the same checks. |