[SERVER-47799] AsyncRequestsSender should update replica set monitor in between retries for InterruptedAtShutdown Created: 27/Apr/20 Updated: 29/Oct/23 Resolved: 21/May/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying, Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.20, 4.2.8, 4.4.0-rc8, 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Matthew Saltz (Inactive) | Assignee: | Janna Golden |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v4.4, v4.2, v4.0
|
||||||||
| Sprint: | Sharding 2020-05-18, Sharding 2020-06-01 | ||||||||
| Participants: | |||||||||
| Case: | (copied to CRM) | ||||||||
| Description |
|
When the AsyncRequestSender handles an error response, it will try to update the replica set monitor for the shard and retry up to 3 times, using the Shard object's targeter to resolve the new host and port to send the request to. However, it turns out that updateReplSetMonitor doesn't actually do anything for the particular error code InterruptedAtShutdown, which is an Interruption error, a Shutdown error, and a Retriable error, but not a NotMaster error or Network error (which is what updateReplSetMonitor is looking for). So this means that the InterruptedAtShutdown error will get propagated to the client except when:
We should change updateReplSetMonitor to include Shutdown errors in the list of errors that will cause the host to be marked as failed (or otherwise include InterruptedAtShutdown). As a side note, I think the current behavior violates the retryable reads spec but it's hard to tell exactly. |
| Comments |
| Comment by Githook User [ 14/Jul/20 ] |
|
Author: {'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}Message: (cherry picked from commit fbf56a4aee8ccb7bff8d3e8c3c32c7849869bb54) |
| Comment by Githook User [ 02/Jun/20 ] |
|
Author: {'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}Message: (cherry picked from commit fbf56a4aee8ccb7bff8d3e8c3c32c7849869bb54) |
| Comment by Githook User [ 02/Jun/20 ] |
|
Author: {'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}Message: (cherry picked from commit fbf56a4aee8ccb7bff8d3e8c3c32c7849869bb54) |
| Comment by Githook User [ 20/May/20 ] |
|
Author: {'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}Message: |