[SERVER-47814] Tests that pass a custom ReplSetTest to RollbackTest should enable the 'setSmallOplogGetMoreMaxTimeMS' failpoint Created: 28/Apr/20  Updated: 29/Oct/23  Resolved: 28/Apr/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Major - P3
Reporter: William Schultz (Inactive) Assignee: William Schultz (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-44068 Investigate the slowest sections of R... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2020-05-04
Participants:

 Description   

Some tests create their own ReplSetTest and pass it in to be used by a RollbackTest instance. If they don't enable the 'setSmallOplogGetMoreMaxTimeMS' failpoint on replica set nodes, it can make RollbackTest execution very slow, due to the problem described in SERVER-45400. We should have these tests enable this failpoint and/or require that it is enabled for a ReplSetTest that is passed in to RollbackTest.



 Comments   
Comment by Githook User [ 28/Apr/20 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-47814 Set fast getMore failpoint for all ReplSetTest instances used by RollbackTest
Branch: master
https://github.com/mongodb/mongo/commit/11fb21f9cdec2e63da0fb09438b34c05c5d73f67

Comment by William Schultz (Inactive) [ 28/Apr/20 ]

The tests that use the rollback_index_builds_test.js fixture are one primary example of this, with some test run times exceeding several minutes:

[2020/04/27 21:56:09.199] [executor:js_test:job5] 2020-04-27T21:56:09.198+0000 rollback_index_build_start_not_create.js ran in 64.43 seconds: no failures detected.
[2020/04/27 21:59:36.459] [executor:js_test:job4] 2020-04-27T21:59:36.459+0000 rollback_index_build_start.js ran in 65.56 seconds: no failures detected.
[2020/04/27 22:01:06.985] [executor:js_test:job3] 2020-04-27T22:01:06.985+0000 rollback_index_build_and_create.js ran in 64.72 seconds: no failures detected.
[2020/04/27 22:01:15.418] [executor:js_test:job4] 2020-04-27T22:01:15.417+0000 rollback_index_build_start_abort_not_create.js ran in 64.77 seconds: no failures detected.
[2020/04/27 22:02:17.221] [executor:js_test:job5] 2020-04-27T22:02:17.221+0000 rollback_index_build_start_abort.js ran in 217.78 seconds: no failures detected.
[2020/04/27 22:04:22.449] [executor:js_test:job11] 2020-04-27T22:04:22.449+0000 rollback_index_build_start_commit.js ran in 217.82 seconds: no failures detected.
[2020/04/27 22:06:10.747] [executor:js_test:job9] 2020-04-27T22:06:10.747+0000 rollback_index_build_start_commit_drop.js ran in 341.85 seconds: no failures detected

Generated at Thu Feb 08 05:15:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.