[SERVER-47902] Ensure ninja's generator local_pool has real concurrency Created: 01/May/20  Updated: 29/Oct/23  Resolved: 12/May/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.4.0-rc6, 4.7.0

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Dev Platform 2020-05-18
Participants:

 Description   

The SCons ninja generator uses the SCons concurrency setting to configure the local_pool in the generated build.ninja, which constrains the number of local jobs. Unfortunately, the detection in SCons happens too late, and the local_pool always ends up having depth 1. This greatly slows down the early part of the build where we are doing things like generating files from IDL, which uses the local concurrency.

We can also be a little smarter about preventing misconfiguration by the user.



 Comments   
Comment by Githook User [ 13/May/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-47902 Ensure ninja generators local_pool has real concurrency

(cherry picked from commit 4423364192774ed484dedd943a0bd1f04fd84e41)
Branch: v4.4
https://github.com/mongodb/mongo/commit/7889448902f34adeaf5f821e056a7a1ed0bf62a2

Comment by Githook User [ 12/May/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-47902 Ensure ninja generators local_pool has real concurrency
Branch: master
https://github.com/mongodb/mongo/commit/4423364192774ed484dedd943a0bd1f04fd84e41

Generated at Thu Feb 08 05:15:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.