[SERVER-47926] Less verbose uassert Created: 04/May/20 Updated: 12/Nov/20 Resolved: 12/Nov/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Lingzhi Deng | Assignee: | Benjamin Caimano (Inactive) |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Sprint: | Service arch 2020-05-18 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
Currently, uasserts log at debug level D1. As we move to more use of exceptions to deal with error handling, we should probably consider adjusting our logging policy for uasserts. Maybe we should only log when we're returning an error to the user instead of whenever we throw an exception. |
| Comments |
| Comment by Lingzhi Deng [ 12/Nov/20 ] |
|
Sounds good to me. Thanks for the work! |
| Comment by Benjamin Caimano (Inactive) [ 12/Nov/20 ] |
|
Alright, I'm closing this as a duplicate of both |
| Comment by Amirsaman Memaripour [ 25/Jun/20 ] |
|
Now that we have internalAssert ( |
| Comment by Benjamin Caimano (Inactive) [ 19/May/20 ] |
|
Apologies on the slow response, it's been a busy couple of weeks. Laying out my thoughts:
|
| Comment by Andy Schwerin [ 04/May/20 ] |
|
Hmmm... iassert? Having the exceptions built and thrown by a helper has been useful. |
| Comment by Lingzhi Deng [ 04/May/20 ] |
|
Yes, after reading Kelsey's comment in |
| Comment by Eric Milkie [ 04/May/20 ] |
|
I don't think we need to change the behavior of uassert; I think we need to not abuse them as ways of throwing internal exceptions. Instead, we should be using "throw" in these situations. |