[SERVER-48041] Tell icecream about sanitizer blacklist files Created: 08/May/20  Updated: 29/Oct/23  Resolved: 24/Jul/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.4.1, 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Ryan Egesdahl (Inactive)
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Dev Platform 2020-07-27
Participants:

 Description   

I think we can make this work by using ICECC_EXTRAFILES.



 Comments   
Comment by Githook User [ 06/Aug/20 ]

Author:

{'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}

Message: SERVER-48041 Package santizer blacklist files in icecream environments

Before this point, remote builds did not work because Icecream did not
copy sanitizer blacklist files to the remote hosts. We had a check in
place that silently turned Icecream builds with sanitizers into local
builds. Now we build the sanitizer blacklist files into the environment
tarball that Icecream uses for remote builds.

(cherry picked from commit cdab099b95de7e2ea7aa9cf23ede566189a35756)
Branch: v4.4
https://github.com/mongodb/mongo/commit/535184a95e0f93fc18cfc449cb09b69418115c1c

Comment by Andrew Morrow (Inactive) [ 24/Jul/20 ]

Tagging for backport to v4.4 to keep build system behavior parity.

Comment by Githook User [ 24/Jul/20 ]

Author:

{'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}

Message: SERVER-48041 Package santizer blacklist files in icecream environments

Before this point, remote builds did not work because Icecream did not
copy sanitizer blacklist files to the remote hosts. We had a check in
place that silently turned Icecream builds with sanitizers into local
builds. Now we build the sanitizer blacklist files into the environment
tarball that Icecream uses for remote builds.
Branch: master
https://github.com/mongodb/mongo/commit/cdab099b95de7e2ea7aa9cf23ede566189a35756

Comment by Ryan Egesdahl (Inactive) [ 17/Jul/20 ]

As it happens, we do want `ICECC_EXTRAFILES` (or `--addfile`). The problem with using it was that we weren't using the absolute path to the blacklist file in the compiler flag. If we do both, this works - assuming the problems in SERVER-47598 don't cause other wacky behavior.

Comment by Andrew Morrow (Inactive) [ 27/May/20 ]

Actually, ICECC_EXTRAFILES doesn't do what we want, but it appears that new enough icecc does know about these. So we can add a version check to icecream.py and allow use of sanitizer builds with icecream if the local version is new enough.

Generated at Thu Feb 08 05:15:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.