[SERVER-48041] Tell icecream about sanitizer blacklist files Created: 08/May/20 Updated: 29/Oct/23 Resolved: 24/Jul/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.1, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Ryan Egesdahl (Inactive) |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v4.4
|
||||
| Sprint: | Dev Platform 2020-07-27 | ||||
| Participants: | |||||
| Description |
|
I think we can make this work by using ICECC_EXTRAFILES. |
| Comments |
| Comment by Githook User [ 06/Aug/20 ] |
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Before this point, remote builds did not work because Icecream did not (cherry picked from commit cdab099b95de7e2ea7aa9cf23ede566189a35756) |
| Comment by Andrew Morrow (Inactive) [ 24/Jul/20 ] |
|
Tagging for backport to v4.4 to keep build system behavior parity. |
| Comment by Githook User [ 24/Jul/20 ] |
|
Author: {'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}Message: Before this point, remote builds did not work because Icecream did not |
| Comment by Ryan Egesdahl (Inactive) [ 17/Jul/20 ] |
|
As it happens, we do want `ICECC_EXTRAFILES` (or `--addfile`). The problem with using it was that we weren't using the absolute path to the blacklist file in the compiler flag. If we do both, this works - assuming the problems in |
| Comment by Andrew Morrow (Inactive) [ 27/May/20 ] |
|
Actually, ICECC_EXTRAFILES doesn't do what we want, but it appears that new enough icecc does know about these. So we can add a version check to icecream.py and allow use of sanitizer builds with icecream if the local version is new enough. |