[SERVER-48077] implicit conversion from 'unsigned long' to 'double' Created: 11/May/20  Updated: 29/Oct/23  Resolved: 08/Mar/22

Status: Closed
Project: Core Server
Component/s: Build, Security
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Jiang Li Assignee: Mohammad Dashti (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

Compile with clang-10

Sprint: QO 2022-03-21
Participants:

 Description   

src/third_party/mozjs-60/include/mozilla/FastBernoulliTrial.h:368:21: warning: implicit conversion from 'unsigned long' to 'double' changes value from 1844674
4073709551615 to 18446744073709551616 [-Wimplicit-int-float-conversion]
 if (skipCount < SIZE_MAX)
                       ~ ^~~~~~~~
 
/usr/include/stdint.h:227:22: note: expanded from macro 'SIZE_MAX'
# define SIZE_MAX (18446744073709551615UL)



 Comments   
Comment by Mohammad Dashti (Inactive) [ 08/Mar/22 ]

ethan.zhang The issue is resolved after the MozJS upgrade: https://github.com/mongodb/mongo/blob/26bab136615f5f7a5d6c35e767e2321dcc31b956/src/third_party/mozjs/include/mozilla/FastBernoulliTrial.h#L370

Comment by Ethan Zhang (Inactive) [ 08/Mar/22 ]

Now we closed SERVER-61008, assigning to mohammad.dashti to confirm if this is already resolved.
Mohammad, please close this ticket if it is no longer an issue. Thanks!

Comment by Andrew Morrow (Inactive) [ 18/May/20 ]

This is a warning in third party code, so we are not in a position to address it directly. I'm leaving this queued up for our next toolchain spin. Or, an upgrade of MozJS may resolve it, whichever happens first.

Generated at Thu Feb 08 05:16:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.