[SERVER-48160] remove IndexBuildsCoordinator::_tryAbort() fatal assertion 4656001 for missing index build thread Created: 12/May/20  Updated: 29/Oct/23  Resolved: 15/May/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.4.0-rc10, 4.7.0

Type: Improvement Priority: Minor - P4
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
is related to SERVER-46560 Make Abort index build logic determin... Closed
is related to SERVER-47605 Single-phase index builds should only... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Execution Team 2020-05-18
Participants:
Linked BF Score: 18

 Description   

Consider removing the fatal assertion for 4656001; or convert to a non-fatal user assertion.

In IndexBuildsCoordinator::_tryAbort(), it is a fatal error if we are unable to look up the OperationContext of an index build to interrupt using the ReplIndexBuildState::opId (set at index build startup). This fatal assertion was originally introduced in SERVER-46560. Until SERVER-47605, we would occasionally hit this fatal assertion during testing.

This assertion does not really suggest a crash-worthy scenario because if the OperationContext for an index build cannot be found, it would mean that the index build has completed (committed or aborted) and there would not be any OperationContext to interrupt for the user-initiated abort request.



 Comments   
Comment by Githook User [ 12/Jun/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48160 IndexBuildsCoordinator::_tryAbort() proceeds with abort if index build thread is not running

(cherry picked from commit 38d66e6ba3e01b3fb817c655decd077c9d9d7b0d)
Branch: v4.4
https://github.com/mongodb/mongo/commit/105e76edc52531274328fc051d6842a4c0c0686b

Comment by Githook User [ 14/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48160 IndexBuildsCoordinator::_tryAbort() proceeds with abort if index build thread is not running
Branch: master
https://github.com/mongodb/mongo/commit/38d66e6ba3e01b3fb817c655decd077c9d9d7b0d

Generated at Thu Feb 08 05:16:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.