[SERVER-48162] resmokelib combine_benchmark_results hook intolerant of unexpected json elements Created: 12/May/20  Updated: 29/Oct/23  Resolved: 13/May/20

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Related
is related to SERVER-41567 Update Benchmark to version 1.5.0 Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service arch 2020-05-18
Participants:
Linked BF Score: 50

 Description   

The newer version of benchmark upgrade added a "host_name" field to the json report. It looks like combine_benchmark_results.py parses a json output document emitted by the benchmark run. Unfortunately it can't tolerate additional elements that might be present in that document. I think that's a future-proofing bug in combine_benchmark_results.py. I'll try to fix it.

Addressing this so that upgrades to benchmark that add extra info fields without changing the old fields don't break our analysis tools.



 Comments   
Comment by Githook User [ 13/May/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-48162 tolerate new benchmark report fields
Branch: master
https://github.com/mongodb/mongo/commit/32673beb9193176de717feb7cd8d37c6b580f32d

Comment by Billy Donahue [ 12/May/20 ]

CR https://mongodbcr.appspot.com/589220037/

Generated at Thu Feb 08 05:16:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.