[SERVER-48164] Ninja build task must not use non-default install options Created: 12/May/20  Updated: 29/Oct/23  Resolved: 14/May/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.4.0-rc7, 4.7.0

Type: Bug Priority: Major - P3
Reporter: Ryan Egesdahl (Inactive) Assignee: Ryan Egesdahl (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Dev Platform 2020-05-18
Participants:
Linked BF Score: 44

 Description   

Ninja build regression tests are not building because install-mode=hardlink is being used unconditionally for all tests. This doesn't work for the ninja tests due to a related change that specifically disallows non-default install modes.



 Comments   
Comment by Githook User [ 18/May/20 ]

Author:

{'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}

Message: SERVER-48164 Override install-action in individual tests

In a previous commit, install-action was set to hardlink for all tests
to reduce resource usage. However, that option doesn't work for one of
the tests. The reasons why it doesn't work are beyond the scope of this
commit, but it probably won't be the last time we need to change the
install mode for a single test, either.

The global install-action will now default to hardlink but can also be
overridden in a test where it is incompatible or where we have reasons
to use a different install-action.

(cherry picked from commit ece6d35fbe5337fc9ce22094367905e5cab712ff)
Branch: v4.4
https://github.com/mongodb/mongo/commit/c2538d1ddc7fcb0cc6fd17a2e0b54c1490ecaaf2

Comment by Githook User [ 14/May/20 ]

Author:

{'name': 'Ryan Egesdahl', 'email': 'ryan.egesdahl@mongodb.com', 'username': 'deriamis'}

Message: SERVER-48164 Override install-action in individual tests

In a previous commit, install-action was set to hardlink for all tests
to reduce resource usage. However, that option doesn't work for one of
the tests. The reasons why it doesn't work are beyond the scope of this
commit, but it probably won't be the last time we need to change the
install mode for a single test, either.

The global install-action will now default to hardlink but can also be
overridden in a test where it is incompatible or where we have reasons
to use a different install-action.
Branch: master
https://github.com/mongodb/mongo/commit/ece6d35fbe5337fc9ce22094367905e5cab712ff

Comment by Andrew Morrow (Inactive) [ 13/May/20 ]

This is also broken on the v4.4 branch, so we will want to backport this.

Comment by Ryan Egesdahl (Inactive) [ 12/May/20 ]

I like the idea of using hardlinks where we can. It looks like we only generate ninja in one place in the file, and it's the only one where we can't use the option. We could probably just make adding the --install-mode=hardlink flag contingent on the task name not being "compile_ninja" so we can get around this.

Generated at Thu Feb 08 05:16:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.