[SERVER-48171] replace OperationContext with Interruptible in FailPoint API Created: 12/May/20  Updated: 29/Oct/23  Resolved: 15/May/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Minor - P4
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-44775 Make FailPoint::pauseWhileSet increme... Closed
is related to SERVER-39165 Add waitForFailpoint command Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2020-05-18, Execution Team 2020-06-01
Participants:

 Description   

The FailPoint interface allows waiters to be interrupted while waiting on a fail point in FailPoint::pauseWhileSet() and FailPoint::waitForTimesEntered(). These two functions currently accept OperationContext but the interruptible sleep function is really part of the base class Interruptible::sleepFor(). These functions currently do not support callers that might want to pass in other classes derived from Interruptible (such as Interruptible::notInterruptible).



 Comments   
Comment by Githook User [ 15/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48171 update fail point usage in indexbuildentryhelpers::getIndexBuildEntry()
Branch: master
https://github.com/mongodb/mongo/commit/065d4ab364de1fc6b54a500848c5b8c33035ad22

Comment by Githook User [ 15/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48171 consolidate implementations for FailPoint waiting functions
Branch: master
https://github.com/mongodb/mongo/commit/81acea044bd20afdf628bd29f9d5d7666057da4a

Comment by Githook User [ 15/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48171 FailPoint wait functions accept Interruptible
Branch: master
https://github.com/mongodb/mongo/commit/e9d23f4045e9a79bf6caa325da4190da2deb3cc1

Comment by Githook User [ 15/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48171 add missing headers to .cpp files in preparation for FailPoint API change
Branch: master
https://github.com/mongodb/mongo/commit/2787a803ac9a79b3bd55f73d400680e3ba975497

Comment by Billy Donahue [ 12/May/20 ]

I agree. There's nothing OperationContext specific about that sleep_for call or about FailPoint API.

Generated at Thu Feb 08 05:16:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.