[SERVER-48171] replace OperationContext with Interruptible in FailPoint API Created: 12/May/20 Updated: 29/Oct/23 Resolved: 15/May/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Execution Team 2020-05-18, Execution Team 2020-06-01 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
The FailPoint interface allows waiters to be interrupted while waiting on a fail point in FailPoint::pauseWhileSet() and FailPoint::waitForTimesEntered(). These two functions currently accept OperationContext but the interruptible sleep function is really part of the base class Interruptible::sleepFor(). These functions currently do not support callers that might want to pass in other classes derived from Interruptible (such as Interruptible::notInterruptible). |
| Comments |
| Comment by Githook User [ 15/May/20 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 15/May/20 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 15/May/20 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 15/May/20 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Billy Donahue [ 12/May/20 ] |
|
I agree. There's nothing OperationContext specific about that sleep_for call or about FailPoint API. |