[SERVER-48196] Upgrade the timelib to the latest to update the built-in timezone files to the latest Created: 13/May/20 Updated: 29/Oct/23 Resolved: 20/Jan/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework, Querying |
| Affects Version/s: | 4.4.0 |
| Fix Version/s: | 6.3.0-rc0, 6.0.6, 4.4.22, 5.0.18 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Yoon Soo Kim |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | query-director-triage | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Assigned Teams: |
Query Execution
|
||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||||||||||||||||||
| Backport Requested: |
v6.3, v6.0, v5.0, v4.4
|
||||||||||||||||||||||||||||||||
| Sprint: | QE 2022-10-31, QE 2022-11-14, QE 2022-11-28, QE 2022-12-12, QE 2022-12-26, QE 2023-01-09, QE 2023-01-23 | ||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||
| Case: | (copied to CRM) | ||||||||||||||||||||||||||||||||
| Description |
|
There has been a new release 2022g of timezone files. We should consider upgrading the builtin timezone rules, and potentially backporting. This release includes the move of Mexico away from supporting DST (Daylight Saving Time) Update: The original request was to update the built-in timezone files but it's preferred to upgrade a third party library as a whole for all third party libraries if there's an official release so as to avoid any hassles (mostly resolving merge conflicts between custom changes and vanilla version) to deal with custom changes to each third party library. So, we upgrade the whole timelib instead of updating only the built-in timezone files. But note that the timelib owner does not release a separate version for each timezone db release. So, probably we need to update timezone files only when there's no separate release. Still it would be worth asking the timelib owner whether he's willing to release a separate version even though there's no separate release yet. |
| Comments |
| Comment by Githook User [ 18/Apr/23 ] |
|
Author: {'name': 'Gil Alon', 'email': 'gil.alon@mongodb.com', 'username': 'galon1'}Message: |
| Comment by Githook User [ 17/Apr/23 ] |
|
Author: {'name': 'Gil Alon', 'email': 'gil.alon@mongodb.com', 'username': 'galon1'}Message: |
| Comment by Githook User [ 12/Apr/23 ] |
|
Author: {'name': 'Yoonsoo Kim', 'email': 'yoonsoo.kim@mongodb.com', 'username': 'yun-soo'}Message: (cherry picked from commit fdb3ed4c149c5eb38ae422f5fde4f29f411fdb07) |
| Comment by Kyle Suarez [ 12/Apr/23 ] |
|
yoonsoo.kim@mongodb.com, sure, I'll flag the backports for director triage and bernard.gorman@mongodb.com and I will find an assignee. |
| Comment by Yoon Soo Kim [ 06/Apr/23 ] |
|
kyle.suarez@mongodb.com, is there any chance for anyone from the QE team to take backports? I have too many things on my plate and am a bit overwhelmed right now. I recorded detailed steps that I followed. It should not be that hard to backport this. |
| Comment by Githook User [ 20/Jan/23 ] |
|
Author: {'name': 'Yoonsoo Kim', 'email': 'yoonsoo.kim@mongodb.com', 'username': 'yun-soo'}Message: |
| Comment by Mohammad Dashti (Inactive) [ 19/Jan/23 ] |
|
Yoon Soo, thanks for checking with Derick. Also, while you are at it, it's best if you could remove the postfix from the lib directory name, i.e., the directory name should be timelib rather than timelib-2022.02. This approach is taken with all recent third-party library upgrades. |
| Comment by Mohammad Dashti (Inactive) [ 19/Jan/23 ] |
|
yoonsoo.kim@mongodb.com As alberto.massari@mongodb.com suggested on Slack, it's preferable to avoid cherry-picking and do an entire library upgrade. It's worth contacting Derick and asking to create a release tag. If Derick doesn't make a release tag timely, it's fine to go with cherry-picking. The prior instances of cherry-picking were of this nature (which Derick was reluctant to create a release tag). |
| Comment by Kyle Suarez [ 19/Jan/23 ] |
|
Updated the title to say we'd like the latest release possible, barring complications |
| Comment by Kyle Suarez [ 11/Nov/22 ] |
|
I'll look for an engineer on the North America side (preferably someone who is just wrapping up a project) to pick this up. |
| Comment by James Wahlin [ 31/Oct/22 ] |
|
Repurposing this ticket to handle an upgrade to 2022f which includes the change made by Mexico to not support DST, effective October 30th, 2022.
|
| Comment by Craig Homa [ 26/May/20 ] |
|
Assigning to QO to triage due to its relationship to |