[SERVER-48220] Complete TODO listed in SERVER-47611 Created: 14/May/20  Updated: 29/Oct/23  Resolved: 26/May/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Vlad Rachev (Inactive)
Resolution: Fixed Votes: 0
Labels: autogen-todo
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-47611 Re-work to_local_args function using ... Closed
Backwards Compatibility: Fully Compatible
Sprint: STM 2020-06-15
Participants:

 Description   

There is a TODO in the codebase referencing a resolved ticket which is assigned to you.

Please follow this link to see the lines of code referencing this resolved ticket:
https://github.com/mongodb/mongo/search?q=SERVER-47611&type=Code

The next steps for this ticket are to either remove the outdated TODO or follow the steps in the TODO if it is correct. If the latter, please update the summary and description of this ticket to represent the work you're actually doing.



 Comments   
Comment by Githook User [ 26/May/20 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-48220 Complete TODO listed in SERVER-47611
Branch: master
https://github.com/mongodb/mongo/commit/98861bb66dfecae67573b79a64ad03942fa3a5e8

Comment by Brooke Miller [ 19/May/20 ]

SGTM! 

Comment by Vlad Rachev (Inactive) [ 18/May/20 ]

Hey brooke.miller I chatted with Ryan and I'm gonna knock this one out as I already looked through the PR and know what needs to be changed. Gonna assign to myself again.

Comment by Vlad Rachev (Inactive) [ 15/May/20 ]

Hey ryan.timmons it seems that you undid part of my change in SERVER-47611 in SERVER-47590. I had uncommented https://github.com/mongodb/mongo/blob/master/buildscripts/resmokelib/run/__init__.py#L169-L175 and maybe you didn't rebase on top of it. The actual changes for to_local_args seem intact (we have tests for the function itself, and those are still passing).

Good reason to add testing for the commands themselves though.

Generated at Thu Feb 08 05:16:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.