[SERVER-48329] Adjust naming of action_type.h on either master or all stable branches Created: 20/May/20 Updated: 29/Oct/23 Resolved: 18/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.20, 4.4.0-rc11, 4.2.9 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v4.2, v4.0, v3.6
|
||||
| Sprint: | Dev Platform 2020-06-29 | ||||
| Participants: | |||||
| Description |
|
In SERVER-43187, the action_type.h header went from being generated to being non-generated. Because the filename did not include the _gen.h suffix on the old branches, the renaming has created a situation where moving back and forth from v4.4 (and presumably older) to master causes a build break. We should probably either rename the action_type.h header on master, or adjust it on old stables so that the generator produces action_type_gen.h along with a forwarding header. This would remove the build breakage that happens while moving across these branches. |
| Comments |
| Comment by Githook User [ 25/Jun/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: (cherry picked from commit 7b3a64c4015780aa65efb8c35fb63e42b1f4d584) |
| Comment by Githook User [ 24/Jun/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: (cherry picked from commit 7b3a64c4015780aa65efb8c35fb63e42b1f4d584) |
| Comment by Githook User [ 18/Jun/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: |