[SERVER-48329] Adjust naming of action_type.h on either master or all stable branches Created: 20/May/20  Updated: 29/Oct/23  Resolved: 18/Jun/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.0.20, 4.4.0-rc11, 4.2.9

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2, v4.0, v3.6
Sprint: Dev Platform 2020-06-29
Participants:

 Description   

In SERVER-43187, the action_type.h header went from being generated to being non-generated.

Because the filename did not include the _gen.h suffix on the old branches, the renaming has created a situation where moving back and forth from v4.4 (and presumably older) to master causes a build break.

We should probably either rename the action_type.h header on master, or adjust it on old stables so that the generator produces action_type_gen.h along with a forwarding header.

This would remove the build breakage that happens while moving across these branches.



 Comments   
Comment by Githook User [ 25/Jun/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-48329 Rename generated action_type files to be less fragile

(cherry picked from commit 7b3a64c4015780aa65efb8c35fb63e42b1f4d584)
(cherry picked from commit b037cec82244abb819d89b20600c8b0c458b3ad5)
Branch: v4.0
https://github.com/mongodb/mongo/commit/b1bea7b2a7cd55311d5dbee4758d96e6235377c7

Comment by Githook User [ 24/Jun/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-48329 Rename generated action_type files to be less fragile

(cherry picked from commit 7b3a64c4015780aa65efb8c35fb63e42b1f4d584)
Branch: v4.2
https://github.com/mongodb/mongo/commit/b037cec82244abb819d89b20600c8b0c458b3ad5

Comment by Githook User [ 18/Jun/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-48329 Rename generated action_type files to be less fragile
Branch: v4.4
https://github.com/mongodb/mongo/commit/7b3a64c4015780aa65efb8c35fb63e42b1f4d584

Generated at Thu Feb 08 05:16:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.