[SERVER-48356] logv2 cleanup db/commands Created: 21/May/20  Updated: 29/Oct/23  Resolved: 28/May/20

Status: Closed
Project: Core Server
Component/s: Logging
Affects Version/s: None
Fix Version/s: 4.4.0-rc8, 4.7.0

Type: Bug Priority: Major - P3
Reporter: Bruce Lucas (Inactive) Assignee: Sara Golemon
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
Backwards Compatibility: Minor Change
Operating System: ALL
Backport Requested:
v4.4
Sprint: Security 2020-06-01
Participants:

 Description   

Looks like we may have missed a couple messages in SERVER-48084:

src/mongo/db/commands/fsync.cpp 20466
src/mongo/db/commands/create_indexes.cpp 20438
src/mongo/db/commands/create_indexes.cpp 20448

sara.golemon I'm just assigning directly to you since you did SERVER-48084, but please do reassign if that's not appropriate.



 Comments   
Comment by Githook User [ 29/May/20 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-48356 Update logv2 messages in db/commands

(cherry picked from commit 27932e29d1d08fe2e3337af301c73d555e327a25)
Branch: v4.4
https://github.com/mongodb/mongo/commit/20fd5b01ac287a75f8975b8ccfa16aab280b4bf8

Comment by Githook User [ 29/May/20 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-48356 Update logv2 messages in db/commands

(cherry picked from commit 27932e29d1d08fe2e3337af301c73d555e327a25)
Branch: v4.4
https://github.com/mongodb/mongo/commit/20fd5b01ac287a75f8975b8ccfa16aab280b4bf8

Comment by Githook User [ 29/May/20 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-48356 Update logv2 messages in db/commands

(cherry picked from commit 27932e29d1d08fe2e3337af301c73d555e327a25)
Branch: v4.4
https://github.com/mongodb/mongo/commit/20fd5b01ac287a75f8975b8ccfa16aab280b4bf8

Comment by Githook User [ 29/May/20 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-48356 Update logv2 messages in db/commands

(cherry picked from commit 27932e29d1d08fe2e3337af301c73d555e327a25)
Branch: v4.4
https://github.com/mongodb/mongo/commit/20fd5b01ac287a75f8975b8ccfa16aab280b4bf8

Comment by Githook User [ 28/May/20 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-48356 Update logv2 messages in db/commands
Branch: master
https://github.com/mongodb/mongo/commit/27932e29d1d08fe2e3337af301c73d555e327a25

Comment by Bruce Lucas (Inactive) [ 27/May/20 ]

Thanks for looking Sara. The issue with those two is that we by convention use "namespace" as the attribute name.

Comment by Sara Golemon [ 27/May/20 ]

Confirmed 20466 needs a touch, but the other two look okay. Could you confirm what needs work?

20438 was touched by Benety with a commit date of Apr 2nd 2020 and currently looks like:

LOGV2(20438,
  "Registering index build",
  "buildUUID"_attr = buildUUID,
  "ns"_attr = ns,
  "collectionUUID"_attr = *collectionUUID,
  "indexes"_attr = specs.size(),
  "firstIndex"_attr = specs[0][IndexDescriptor::kIndexNameFieldName]);

20448 is one I did update recently (May 11th 2020) and currently looks like:

LOGV2(20448,
  "Index build failed: collection dropped",
  "buildUUID"_attr = buildUUID,
  "ns"_attr = ns, 
  "collectionUUID"_attr = *collectionUUID,
  "exception"_attr = ex);

Generated at Thu Feb 08 05:16:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.