[SERVER-48359] retry voteCommitIndexBuild on new primary if current primary is shutting down Created: 21/May/20  Updated: 29/Oct/23  Resolved: 22/May/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.4.0-rc7, 4.7.0

Type: Bug Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
is related to SERVER-46910 2 phase index builds should not try t... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Execution Team 2020-06-01
Participants:
Linked BF Score: 14

 Description   

When a secondary index build is ready to vote for commit readiness (using the voteCommitIndexBuild command in the IndexBuildsCoordinatorMongod::_checkVoteCommitIndexCmdSucceeded()), it may receive a ShutdownError if the remote primary is in the process of shutting down. This can lead to the secondary to stop the voting process prematurely.



 Comments   
Comment by Githook User [ 26/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48359 IndexBuildsCoordinatorMongod::_signalPrimaryForCommitReadiness() should not throw on remote shutdown error

(cherry picked from commit 935fce45d2074ad9bc68fb9c5b05ed73e5fdc186)
Branch: v4.4
https://github.com/mongodb/mongo/commit/b54c9c8f37783b8d8906988cd8c5f7625582f5cb

Comment by Githook User [ 22/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-48359 IndexBuildsCoordinatorMongod::_signalPrimaryForCommitReadiness() should not throw on remote shutdown error
Branch: master
https://github.com/mongodb/mongo/commit/935fce45d2074ad9bc68fb9c5b05ed73e5fdc186

Comment by Benety Goh [ 21/May/20 ]

It is not clear that the presence of a shutdown error here necessarily implies a local shutdown condition. However, we can rely on this interruption check, introduced in SERVER-46910, at the top of this loop to throw an exception if the current node has started the shutdown process.

Generated at Thu Feb 08 05:16:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.