[SERVER-48360] Bypass compile is broken Created: 21/May/20 Updated: 29/Oct/23 Resolved: 11/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Vlad Rachev (Inactive) | Assignee: | Jeffrey Zambory |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Steps To Reproduce: |
Also think the task should system-fail if we fail to bypass-compile so we wouldn't hide the failure. |
| Sprint: | DAG 2020-06-15 |
| Participants: | |
| Story Points: | 2 |
| Description |
|
Bypass compile is a script that looks at the files changed in your patch build and determines if they could have an impact on the compile artifacts. If they shouldn't have any impact, it will download binaries from the mainline build the patch is built off instead of actually compiling. This saves a large chunk of compile time. It looks like the problem here is that one of the compile artifacts we are attempting to download is named differently on windows than on other platforms. We store the artifacts to download in a dictionary. It seems like we need to handle the windows-case better. As far as system-failing when bypass-compile files, when bypass compile was originally written, the decision was made to explicitly not fail on error, since then we would just do the compile as normal and the only impact would be that the compile task takes longer. That makes sense, but it means that when bypass-compile breaks, we get no notice and it likely stays broken until someone digs into the task logs. I don't think we should change that behavior in this ticket, but it is something that might be worth a discussion. |
| Comments |
| Comment by Githook User [ 11/Jun/20 ] | ||||||||||||||||||||
|
Author: {'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com'}Message: | ||||||||||||||||||||
| Comment by Vlad Rachev (Inactive) [ 29/May/20 ] | ||||||||||||||||||||
|
Thanks for the description david.bradford. I think I agree with you that we probably shouldn't fail given that bypass-compile is a supplemental feature that doesn't impact the patch itself. | ||||||||||||||||||||
| Comment by Brooke Miller [ 29/May/20 ] | ||||||||||||||||||||
|
David B. will add in details to the description based on our conversation in Story Pointing | ||||||||||||||||||||
| Comment by Vlad Rachev (Inactive) [ 21/May/20 ] | ||||||||||||||||||||
|
Link is pretty slow, here's the trace:
|