[SERVER-48372] Build fails on windows with latest buildtool version released on May 19th Created: 21/May/20 Updated: 29/Oct/23 Resolved: 28/May/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc8, 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Marcos José Grillo Ramirez | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | Windows | ||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||
| Steps To Reproduce: | 1. On Windows 10, Update Visual Studio 2019 to 16.6.0 |
||||||||||||
| Sprint: | Dev Platform 2020-06-01 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
The latest visual studio version (v16.6.0) with the windows compiler version 19.26.28805:
Fails to compile the master branch at least on the revision 300d06e, on the mozjs-60 third party module:
|
| Comments |
| Comment by Githook User [ 28/May/20 ] | ||||||||||||||||||||
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: (cherry picked from commit fa375b0b13a392f64f44fc48df9b152f3fbcc88b) | ||||||||||||||||||||
| Comment by Githook User [ 28/May/20 ] | ||||||||||||||||||||
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: | ||||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 27/May/20 ] | ||||||||||||||||||||
|
marcos.grillo - As discussed on slack. instances of this error in code we own (src/mongo/... should be fixed under a different ticket, since they can be made as direct commits to the codebase. Changes to third_party code can remain in this ticket since they arrive by various other processes. | ||||||||||||||||||||
| Comment by Marcos José Grillo Ramirez [ 27/May/20 ] | ||||||||||||||||||||
|
Hi acm, thank you for taking a look at this. The exact diff do not apply, I had to apply the following diff:
But the compilation still fails, now with the error:
| ||||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 26/May/20 ] | ||||||||||||||||||||
|
marcos.grillo - Could you please try applying the above trivial change and see if it fixes the issue locally for you? And let me know either way. | ||||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 26/May/20 ] | ||||||||||||||||||||
|
We can backport https://github.com/mozilla/gecko-dev/commit/bae79bfe2a76d79173ccf63ecae50e221a21cf4b#diff-81185e9c4143f68ef0ed72a1729157b4 | ||||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 26/May/20 ] | ||||||||||||||||||||
|
This is due to https://docs.microsoft.com/en-us/cpp/overview/cpp-conformance-improvements?view=vs-2019#unnamed-classes-in-typedef-declarations. Since this is a hard error in our build mode, we cannot address this with adding additional flags to control the set of warnings. We will either need to make our own localized fix, or, if a fix has been made upstream, cherry-pick it in to our tree. |