[SERVER-48405] Add missing check for command result in clusterwide_ops_with_add_remove_shards.js Created: 26/May/20  Updated: 24/Aug/23  Resolved: 24/Aug/23

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Tommaso Tocci Assignee: Tommaso Tocci
Resolution: Declined Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: ALL
Sprint: Sharding 2020-06-01
Participants:

 Description   

In here:

https://github.com/mongodb/mongo/blob/99a412444c28051f3839ad07c6a938f6ef8e3a64/jstests/concurrency/fsm_workloads_add_remove_shards/clusterwide_ops_with_add_remove_shards.js#L71

We are ignoring possible errors on the addShard command, since we are not checking the command result.



 Comments   
Comment by Tommaso Tocci [ 29/May/20 ]

After speaking with bernard.gorman the original author of the test I understood that for the purpose of this test we are not interested in checking the command results

Comment by Tommaso Tocci [ 29/May/20 ]

From a probing patch that I run on evergreen with the missing check is it possible to see that actually the command is failing a lot with:

[tid:4] assert: command failed: {
 "ok" : 0,
 "errmsg" : "ReplicaSetMonitor for set shard-rs0 is removed",
 "code" : 199,
 "codeName" : "ReplicaSetMonitorRemoved",
 "operationTime" : Timestamp(1590498158, 260),
 "$clusterTime" : {
 "clusterTime" : Timestamp(1590498158, 278),
 "signature" : {
 "hash" : BinData(0,"AAAAAAAAAAAAAAAAAAAAAAAAAAA="),
 "keyId" : NumberLong(0)
 }
 }
}

 

Generated at Thu Feb 08 05:17:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.