[SERVER-48530] Relax invariant around timestamping for nodes in REMOVED Created: 01/Jun/20  Updated: 29/Oct/23  Resolved: 13/Jul/20

Status: Closed
Project: Core Server
Component/s: Index Maintenance, Replication
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Bug Priority: Major - P3
Reporter: Judah Schvimer Assignee: Matthew Russotto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Issue split
split from SERVER-48480 Abort initial sync upon transition to... Closed
Related
is related to SERVER-47867 Remove ghost timestamping code Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2020-06-29, Repl 2020-07-13, Repl 2020-07-27
Participants:
Linked BF Score: 18

 Description   

This is split from SERVER-48480 for 4.6+. We want to add REMOVED to this check.



 Comments   
Comment by Githook User [ 13/Jul/20 ]

Author:

{'name': 'Matthew Russotto', 'email': 'matthew.russotto@10gen.com', 'username': 'mtrussotto'}

Message: SERVER-48530 Relax invariant around timestamping for nodes in REMOVED
Branch: master
https://github.com/mongodb/mongo/commit/75691902119c31adc7955da52afcff63cc0bf97b

Comment by Matthew Russotto [ 06/Jul/20 ]

I think if it gets to that point, it will invariant but the initial sync will have completed so restarting the node will not restart initial sync. We probably should make a clean transition to REMOVED instead of invariant. I believe we can test this by removing the node during the last failpoint of initial sync.

Comment by Judah Schvimer [ 30/Jun/20 ]

suganthi.mani brought up that this ticket may not be sufficient for allowing initial sync to continue in REMOVED. This invariant might also pose a problem. matthew.russotto, do you think this is a problem? Is there a test we can add to validate that the fix included in this ticket is sufficient?

Generated at Thu Feb 08 05:17:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.