[SERVER-48602] Improve DocumentDiff serialization implementation and testing Created: 04/Jun/20  Updated: 29/Oct/23  Resolved: 10/Jul/20

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Ian Boros Assignee: Arun Banala
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query 2020-07-13, Query 2020-07-27
Participants:

 Description   

Since we are merging a "quick" version in order to unblock other parts of the project, we should come back at the end to optimize them. They currently rely on multiple BSONObjBuilders which hold intermediate state about the diff. This should be avoided.

We should also add more test cases for situations where a DocumentDiffReader is given an invalid/malformed diff.



 Comments   
Comment by Githook User [ 10/Jul/20 ]

Author:

{'name': 'Arun Banala', 'email': 'arun.banala@mongodb.com', 'username': 'banarun'}

Message: SERVER-48602 Improve DocumentDiff serialization implementation and testing
Branch: master
https://github.com/mongodb/mongo/commit/4e358e0a229c517295fd8b823b0fc33741abb36f

Comment by Ian Boros [ 15/Jun/20 ]

This ticket will also cover changing the "sparse array" diff format to encode the type of the diff directly in the key name, as suggested by Arun. For example, an array diff may look something like

{a: true, 'u0': ..., 's5': ..., ...} 

Generated at Thu Feb 08 05:17:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.