[SERVER-48660] FTDCMetricsCollectorMockTee needs to guard _counter Created: 08/Jun/20 Updated: 29/Oct/23 Resolved: 26/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mark Benvenuto | Assignee: | Mina Mahmood (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng, thread-sanitizer | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Sprint: | Security 2020-06-29 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
FTDCMetricsCollectorMockTee in src/mongo/db/ftdc/controller_test.cpp needs to guard writes to _counter with _mutex in order to ensure writes are observed between threads. |
| Comments |
| Comment by Githook User [ 26/Jun/20 ] |
|
Author: {'name': 'Mina Mahmood', 'email': 'mina.mahmood@mongodb.com'}Message: |
| Comment by Mina Mahmood (Inactive) [ 26/Jun/20 ] |
| Comment by Andrew Morrow (Inactive) [ 24/Jun/20 ] |
|
I see this ticket is scheduled in the current sprint but does not currently have an assignee. Would it be possible to bump it up in priority a bit? We are getting very close to having the whole unit tests suite pass under TSAN which will unblock us from moving on to more substantial testing like dbtest which is likely to start giving more valuable signal as to real races which may affect product correctness. |