[SERVER-48660] FTDCMetricsCollectorMockTee needs to guard _counter Created: 08/Jun/20  Updated: 29/Oct/23  Resolved: 26/Jun/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Bug Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Mina Mahmood (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng, thread-sanitizer
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Security 2020-06-29
Participants:
Linked BF Score: 0

 Description   

FTDCMetricsCollectorMockTee in src/mongo/db/ftdc/controller_test.cpp needs to guard writes to _counter with _mutex in order to ensure writes are observed between threads.



 Comments   
Comment by Githook User [ 26/Jun/20 ]

Author:

{'name': 'Mina Mahmood', 'email': 'mina.mahmood@mongodb.com'}

Message: SERVER-48660 Added lock around _counter increment
Branch: master
https://github.com/mongodb/mongo/commit/df5cfdbb62e554f4028bd7effefbde670d8ff76e

Comment by Mina Mahmood (Inactive) [ 26/Jun/20 ]

https://mongodbcr.appspot.com/621120001/

Comment by Andrew Morrow (Inactive) [ 24/Jun/20 ]

I see this ticket is scheduled in the current sprint but does not currently have an assignee. Would it be possible to bump it up in priority a bit? We are getting very close to having the whole unit tests suite pass under TSAN which will unblock us from moving on to more substantial testing like dbtest which is likely to start giving more valuable signal as to real races which may affect product correctness.

Generated at Thu Feb 08 05:17:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.