[SERVER-48688] Improving diagnostics around user assertions Created: 10/Jun/20 Updated: 26/Oct/20 Resolved: 26/Oct/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Diagnostics |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Dmitry Agranat | Assignee: | Benjamin Caimano (Inactive) |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | sa-groomed, servicearch-product-sync | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Sprint: | Service arch 2020-06-29, Service arch 2020-07-13 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
This is more specifically for 4.4 because of higher frequency of "User assertion" but this issue has been around in previous versions too. We'd like to understand what diagnostics value "User assertion" messages have and based on the answer, perhaps do a more general cleanup of today's approach. |
| Comments |
| Comment by Daniel Pasette (Inactive) [ 26/Oct/20 ] |
|
matthew.tretin LGTM |
| Comment by Matthew Tretin (Inactive) [ 20/Oct/20 ] |
|
pasette bruce.lucas dmitry.agranat – We believe that |
| Comment by Benjamin Caimano (Inactive) [ 17/Jun/20 ] |
|
garaudy.etienne, we can't really fix the isMaster uassert issue without providing a way around the general uassert issue. It's a deadline wait, those emit exceptions and we only emit exceptions through custom assert macros. I've filed |
| Comment by Garaudy Etienne [ 17/Jun/20 ] |
|
pasette that makes sense to me. ben.caimano ratika.gandhi can we tackle the isMaster uassert issue first and table the general uassert for later? |
| Comment by Daniel Pasette (Inactive) [ 10/Jun/20 ] |
|
I imagine this issue will generate a fair amount of support load/questions post release. |