[SERVER-48696] signal/sigaction callbacks must have C language linkage Created: 10/Jun/20  Updated: 29/Oct/23  Resolved: 23/Nov/20

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.8.1

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Gabriel Russell (Inactive)
Resolution: Fixed Votes: 0
Labels: servicearch-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-48597 Fix stack trace unit tests with TSAN Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service arch 2020-11-30
Participants:

 Description   

The function pointer accepted by these C functions needs to have C language linkage. We're getting away without the extern "C". , but only by accident of ABI. Technically it's supposed to be there, as it can change the function pointer's type. We should fix it in the few places it happens.

 

(spawned by discussion in review for SERVER-48597).



 Comments   
Comment by Githook User [ 23/Nov/20 ]

Author:

{'name': 'Gabriel Russell', 'email': 'gabriel.russell@mongodb.com', 'username': 'gabrielrussell'}

Message: SERVER-48696 sigaction actions need to all be extern "C"
Branch: master
https://github.com/mongodb/mongo/commit/71fb74aab300a852761e0ae3b0782c207f4aef52

Generated at Thu Feb 08 05:17:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.