[SERVER-48775] Move all Sharding unit-tests that assume a MongoD to the db/s directory Created: 14/Jun/20  Updated: 29/Oct/23  Resolved: 21/Jun/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2020-06-15, Sharding 2020-06-29
Participants:

 Comments   
Comment by Andrew Morrow (Inactive) [ 01/Jul/20 ]

Sure, but it is exactly the "really mongos-specific things" that I want to isolate via physical structure, even if there aren't a lot of them. There may be more in the future, and having some guideposts in the form of physical structure that suggests that certain things shouldn't be linked to other things can be valuable.

Comment by Kaloian Manassiev [ 01/Jul/20 ]

Actually, MongoD implicitly links the router stuff as well, because shards act as routers from time to time (e.g., aggregation). Because of this, all of mongo/s is linked into MongoD, except for the really MongoS-specific things, such as the entry point, which is this library.

Comment by Andrew Morrow (Inactive) [ 23/Jun/20 ]

Hi kaloian.manassiev - This is great, I'm really happy to see us doing this. I do have a question. If mongo/db/s is mongod only, and mongo/s is common between mongos and mongod, where does code that is unique to mongos go?

Comment by Githook User [ 21/Jun/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-48775 Move all Sharding unit-tests that assume a MongoD to the db/s directory

With this change there are no more references from mongo/s (which is
code common between MongoS and MongoD) and mongo/db/s (which is code
specific for MongoD only).
Branch: master
https://github.com/mongodb/mongo/commit/33201c068f9ec37196190be083d61f46dc83d470

Comment by Githook User [ 15/Jun/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-48775 Run dos2unix on two sharding test files with CRLF line endings
Branch: master
https://github.com/mongodb/mongo/commit/b4a4fa2baa5f2367b12123f2933817298ff1142e

Comment by Githook User [ 15/Jun/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-48775 Make all `s_test` suites use the ShardingTestFixture
Branch: master
https://github.com/mongodb/mongo/commit/c4c7c562ba9d038f1a4663079867ce39c4865497

Comment by Githook User [ 15/Jun/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-48775 Make OpObserverShardingImpl to be part of sharding_runtime_d
Branch: master
https://github.com/mongodb/mongo/commit/e1d7052125a3ca7767a81c4737628ba37077d17b

Generated at Thu Feb 08 05:18:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.