[SERVER-48776] Remove config version and term check during the reconfig quorum check Created: 15/Jun/20 Updated: 29/Oct/23 Resolved: 15/Jul/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.1, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Pavithra Vetriselvan | Assignee: | Pavithra Vetriselvan |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||
| Sprint: | Repl 2020-06-29, Repl 2020-07-13, Repl 2020-07-27 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 9 | ||||||||||||||||
| Description |
|
During this step, if we learn that another node has a newer config, we will fail the reconfig command with NewReplicaSetConfigurationIncompatible. This extra check seems unnecessary with the safe reconfig protocol. The error is also confusing in a concurrent stepdown/reconfig scenario:
If we remove the quorum check, we will fail later in the protocol here. This is still safe and also returns a more accurate error (NotMaster). |
| Comments |
| Comment by Githook User [ 20/Aug/20 ] |
|
Author: {'name': 'Pavi Vetriselvan', 'email': 'pavithra.vetriselvan@mongodb.com', 'username': 'pvselvan'}Message: (cherry picked from commit 1c3532ee1941e37f934f6c14bdc7786619d6b258) |
| Comment by Pavithra Vetriselvan [ 15/Jul/20 ] |
|
This is causing BF's on the 4.4 branch so it will need to be backported to 4.4.1. It it not a release blocker. |
| Comment by Githook User [ 15/Jul/20 ] |
|
Author: {'name': 'Pavi Vetriselvan', 'email': 'pavithra.vetriselvan@mongodb.com', 'username': 'pvselvan'}Message: |
| Comment by William Schultz (Inactive) [ 15/Jun/20 ] |
|
Just adding a note that we should make sure to not re-introduce any bugs addressed in |