[SERVER-48793] Remove "targetIndex" from ReplicationCoordinatorImpl::_handleHeartbeatResponse() Created: 15/Jun/20  Updated: 06/Dec/22  Resolved: 09/Oct/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Suganthi Mani Assignee: Backlog - Replication Team
Resolution: Duplicate Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-50318 Only restart scheduled heartbeats Closed
Related
related to SERVER-46379 Implement upgrade/downgrade support f... Closed
Assigned Teams:
Replication
Sprint: Repl 2020-10-19
Participants:

 Description   

This code cleanup was caught duringĀ SERVER-46379. We should remove 'targetIndex' from ReplicationCoordinatorImpl::_handleHeartbeatResponse() to avoid any future mistakes of accessing "targetIndex" in that function, that can lead to server crash. Using targetIndex in replicationCoordinatorImpl::_handleHeartbeatResponse() is not safe because
targetIndex is the target's member index when the heartbeat was sent out by the node. But, a reconfig can make the target's member index to change the when the heart beat response was received by the node. So, ReplicationCoordinatorImpl::_handleHeartbeatResponse() should alway's use target's host and port to access member data from the in-memory config.


Generated at Thu Feb 08 05:18:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.