[SERVER-48900] Remove "format-string" arguments from logv2 statements in query code Created: 16/Jun/20  Updated: 29/Oct/23  Resolved: 20/Aug/20

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: David Storch Assignee: Milena Ivanova
Resolution: Fixed Votes: 0
Labels: neweng, qexec-team
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-48353 logv2 cleanup for db/query, s/query, ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query 2020-08-24
Participants:

 Description   

In related ticket SERVER-48353, we cleaned up the automatically-generated attribute names for logv2 to be more readable. However, many logging statements still provide both a "format-string" and "message-string". In the master branch, only the "message-string" is ever used for structured JSON logs. The "format-string" was necessary during the transition from text logs to JSON logs, but is now vestigial. The "format-strings" reduce readability of the code, since they are largely redundant with the "message-string". We should delete the "format-string" argument from logging statements in the following directories:

  • db/query
  • s/query
  • db/views
  • db/matcher
  • db/exec


 Comments   
Comment by Githook User [ 20/Aug/20 ]

Author:

{'name': 'Milena Ivanova', 'email': 'milena.ivanova@mongodb.com', 'username': 'mivanova3'}

Message: SERVER-48900 Remove format-string arguments from logv2 statements
Branch: master
https://github.com/mongodb/mongo/commit/e54d83a72d47c17241196618d70db35c05e8243a

Generated at Thu Feb 08 05:18:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.