[SERVER-48922] Create internal assertion macro Created: 17/Jun/20 Updated: 29/Oct/23 Resolved: 24/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc12, 4.7.0 |
| Type: | Task | Priority: | Critical - P2 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Amirsaman Memaripour |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||
| Sprint: | Service arch 2020-06-29 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
We now have patterns where we expect failure like here, where failure might be recoverable like here, or where failure accounting isn't interesting like here. We should provide a new macro, internalAssert(), that logs at something like D3 instead of D1 and does not increment counters (see here). We should prove this out by confirming that awaitable isMaster jstests (see here) on both mongod and mongos do not increment the assertion counter. |
| Comments |
| Comment by Githook User [ 25/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: (cherry picked from commit 8f4f4741ad6711896caa78fbd0486e2da00e25e4) |
| Comment by Githook User [ 24/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: |