[SERVER-48959] Remove 4.4 version check in getHashesUsingSessions function in replsettest Created: 18/Jun/20 Updated: 29/Oct/23 Resolved: 11/Aug/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Ali Mir | Assignee: | Wenbin Zhu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Repl 2021-08-23 |
| Participants: |
| Description |
|
In 4.6, we introduced snapshot reads for the dbHash command. In order to account for mixed version sets, we check for a node's binary version in order to determine if we will run new or old 4.4 behavior to do a point-in-time read. Once we branch cut 4.6, we can remove this check in master. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 11/Aug/21 ] |
|
Author: {'name': 'Wenbin Zhu', 'email': 'wenbin.zhu@mongodb.com', 'username': 'WenbinZhu'}Message: |
| Comment by Wenbin Zhu [ 11/Aug/21 ] |
|
Multiversion seems fine since now we only test for 5.1 and 5.0, thanks ali.mir for the offline discussion. For upgrade tests, initially I was concerning if tests like major_version_upgrade.js would break because it tests binaries starting from 4.0, but now I think it should be fine because the test only calls stopSet() (which checks db hash) at the end of the all the upgrades where the binary is already 5.1, instead of start and stop replset at each individual upgrade. |