[SERVER-49074] Change unittest pcrecpp dep from LIBDEP to LIBDEP_PRIVATE Created: 24/Jun/20  Updated: 29/Oct/23  Resolved: 14/Jul/20

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-49141 Coverity build of mongodb/mongo faili... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service arch 2020-06-29, Service arch 2020-07-13
Participants:

 Description   

The ASSERT_STRING_SEARCH_REGEX macro uses pcrecpp inline.

If we moved its regex call into unittest.cpp, we could make pcrecpp a LIBDEP_PRIVATE of the unittest framework and maybe reduce some link costs.



 Comments   
Comment by Githook User [ 14/Jul/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-49074 make pcrecpp LIBDEPS_PRIVATE to unittest
Branch: master
https://github.com/mongodb/mongo/commit/316408d14e2358225e8f26bfe4d4022cfcf748d9

Comment by Billy Donahue [ 24/Jun/20 ]

CR https://mongodbcr.appspot.com/611170013/

Generated at Thu Feb 08 05:18:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.