[SERVER-49157] Initialize WireSpec during MONGO_INITIALIZER Created: 26/Jun/20  Updated: 29/Oct/23  Resolved: 04/Aug/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Bug Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Amirsaman Memaripour
Resolution: Fixed Votes: 0
Labels: servicearch-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-51700 Use TransportLayer to acquire WireSpec Closed
Duplicate
is duplicated by SERVER-48932 ReplicaSetMonitor hitting failpoint s... Closed
Related
related to SERVER-48932 ReplicaSetMonitor hitting failpoint s... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2020-07-27, Service Arch 2020-08-10
Participants:

 Description   

We default initialize the WireSpec on first use here. Unfortunately, this means that we can set isInternalClient late like we do here. We should formally initialize the global WireSpec with a MONGO_INITIALIZER.

It would also be nice if we allowed a TransportLayer to reference a specific WireSpec. It would allow us to switch during our testing or have both internal and external clients in process.



 Comments   
Comment by Githook User [ 04/Aug/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-49157 Make TransportLayer reference a specific WireSpec
Branch: master
https://github.com/mongodb/mongo/commit/45bed9f6033a9c0df0cc54243e4a24aa9ff8bd2a

Comment by Githook User [ 29/Jul/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-49157 Initialize WireSpec during MONGO_INITIALIZER
Branch: master
https://github.com/mongodb/mongo/commit/58283ca178782c4d1c4a4d2acd4313f6f6f86fd5

Comment by Githook User [ 29/Jul/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-49157 Initialize WireSpec during MONGO_INITIALIZER
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/9c81344f645617e0b279a482594d2b7b4231c4c0

Comment by Mira Carey [ 30/Jun/20 ]

I think my preference would be to make it unusable before init, and actually init it in the initializer graph after command line option parsing

Generated at Thu Feb 08 05:19:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.