[SERVER-49168] SYSLIBDEPS needs a PRIVATE variant Created: 29/Jun/20  Updated: 29/Oct/23  Resolved: 27/Aug/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Daniel Moody
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Dev Platform 2020-08-10, Dev Platform 2020-08-24, Dev Platform 2020-09-07
Participants:

 Description   

For LIBDEPS, we offer both a public and a private mode. For SYSLIBDEPS we only offer a public mode. As a result, all SYSLIBDEPS are public.

However, in many cases (perhaps much more often than for LIBDEPS), it is the case that SYSLIBDEPS should be private: a great example is liblzma which is needed for libunwind, but ends up on the link line for almost everything.

Additionally, there are some uses of LIBS in the codebase. These are used mainly at a global level, but do not participate in transitivity at all. We should eliminate all uses of LIBS and use SYSLIBDEPS[_PRIVATE] exclusively to describe system library dependencies.



 Comments   
Comment by Githook User [ 27/Aug/20 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-49168 made SYSLIBDEPS_PRIVATE type and switched lzma to use it
Branch: master
https://github.com/mongodb/mongo/commit/a81e107047d3048cea552ee36ff2ed18e98a2347

Generated at Thu Feb 08 05:19:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.