[SERVER-49197] Prevent build failures with --sanitize=* and icecc Created: 30/Jun/20 Updated: 06/Dec/22 Resolved: 17/Jul/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | 4.5 Required |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Ryan Egesdahl (Inactive) | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Server Development Platform
|
| Operating System: | ALL |
| Sprint: | Dev Platform 2020-07-27 |
| Participants: |
| Description |
|
Icecream as deployed in our fleet currently does not work with sanitizer blacklist files. We have a workaround in place that is supposed to prevent errors such as this: However, if you have icecream enabled, those errors show up regardless of our workaround. It's apparent that the workaround is not working. Based on a review of the relevant code, it looks like the reason the workaround is not operating is because it's looking for sanitizer blacklist files in the command line:
Unfortunately, we are using a SCons builder to replace those command-line options at compile time because we have made the blacklist files a dependency so we can force a rebuild whenever the blacklist files have changed. This means the workaround never sees what it's expecting and is effectively non-operational. Implement a better workaround that disables remote builds when a sanitizer blacklist file is in use. |
| Comments |
| Comment by Ryan Egesdahl (Inactive) [ 17/Jul/20 ] |
|
With the work done in |