[SERVER-49299] Intel decimal version script dependency does not project into ninja Created: 02/Jul/20  Updated: 29/Oct/23  Resolved: 04/Feb/21

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Daniel Moody
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes SERVER-55165 inteldecimal version script should no... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Dev Platform 2021-02-08
Participants:

 Description   

In SERVER-48546 we added a version script to the link step for the intel decimal library. Care was taken to ensure that in SCons, changes to the version script would result in a re-link of the library, since the version script is an input to the link step. However, it appears that the Ninja generator does not pick up this dependency. These version scripts change infrequently so this is unlikely to cause problems for developers right now. However, the same technique is used, for instance, to manage the sanitizer blacklist files, which do sometimes change. We should understand how to define the dependency on the version script or other non-standard build step inputs in the SCons layer in such a way that it is accurately reflected in the Ninja build, or teach the Ninja layer how to properly express the dependencies as currently expressed in SCons.



 Comments   
Comment by Githook User [ 04/Feb/21 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-49299 added explicit depends to inteldecimal for ninja
Branch: master
https://github.com/mongodb/mongo/commit/a970baa23f7ad2ce1bca2f6a169e40ceec3ac5d9

Comment by Andrew Morrow (Inactive) [ 03/Feb/21 ]

daniel.moody - Yes, that's right. I've fixed it above.

Comment by Daniel Moody [ 03/Feb/21 ]

I believe this ticket was meant to reference SERVER-48546 instead of SERVER-49141?

Generated at Thu Feb 08 05:19:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.