[SERVER-49371] Introduce the InlineRecursiveCountingExecutor Created: 08/Jul/20 Updated: 29/Oct/23 Resolved: 17/Aug/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0, 4.4.4 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Benjamin Caimano (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | servicearch-wfbf-day, thread-sanitizer | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||
| Sprint: | Service Arch 2020-07-27, Service Arch 2020-08-10, Service Arch 2020-08-24 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Linked BF Score: | 76 | ||||||||||||||||||||||||
| Description |
|
Both of the stack overflow tests here for SharedPromise were made impotent by changes to the InlineCountingExecutor. The current form using unique_function doesn't require stack space. We can revive the original InlineCountingExecutor here as the InlineRecursiveCountingExecutor (and perhaps rename the other as the InlineQueuedCountingExecutor). |
| Comments |
| Comment by Githook User [ 05/Jan/21 ] |
|
Author: {'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}Message: |
| Comment by Githook User [ 14/Aug/20 ] |
|
Author: {'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}Message: |
| Comment by Githook User [ 07/Aug/20 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: Revert " This reverts commit 72d104ca45461075fc7a4deb11d3522ff24c62f6. |
| Comment by Kaloian Manassiev [ 07/Aug/20 ] |
|
The tests introduced in this change fail consistently the util_test suite, so I am reverting it. |
| Comment by Githook User [ 07/Aug/20 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 07/Aug/20 ] |
|
Author: {'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}Message: |
| Comment by Andrew Morrow (Inactive) [ 14/Jul/20 ] |
|
ben.caimano and reo.kimura - This is one of the remaining two TSAN failures blocking the unit tests from being green (the other being |