[SERVER-49371] Introduce the InlineRecursiveCountingExecutor Created: 08/Jul/20  Updated: 29/Oct/23  Resolved: 17/Aug/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0, 4.4.4

Type: Task Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: servicearch-wfbf-day, thread-sanitizer
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
Related
is related to SERVER-47760 Avoid concurrent accesses to InlineCo... Closed
is related to SERVER-47139 Introduce GuaranteedExecutor class Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Service Arch 2020-07-27, Service Arch 2020-08-10, Service Arch 2020-08-24
Participants:
Linked BF Score: 76

 Description   

Both of the stack overflow tests here for SharedPromise were made impotent by changes to the InlineCountingExecutor. The current form using unique_function doesn't require stack space.

We can revive the original InlineCountingExecutor here as the InlineRecursiveCountingExecutor (and perhaps rename the other as the InlineQueuedCountingExecutor).



 Comments   
Comment by Githook User [ 05/Jan/21 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-49371 Revived original recursive ICE and applied to stack overflow tests
Branch: v4.4
https://github.com/mongodb/mongo/commit/85c24da21e55b0f09f8664ae1724022b65e211a3

Comment by Githook User [ 14/Aug/20 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-49371 Revived original recursive ICE and applied to stack overflow tests
Branch: master
https://github.com/mongodb/mongo/commit/309b039304e6a77465c4fe917dff54fb3d892976

Comment by Githook User [ 07/Aug/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: Revert "SERVER-49371 Revived original recursive ICE and applied to stack overflow tests"

This reverts commit 72d104ca45461075fc7a4deb11d3522ff24c62f6.
This reverts commit 77ce2860da66ab9924c0668c76fae564eb7c7dfc.
Branch: master
https://github.com/mongodb/mongo/commit/21d5a8e5bd822e71e5fb8feb2f9e71a7e8cf25f9

Comment by Kaloian Manassiev [ 07/Aug/20 ]

The tests introduced in this change fail consistently the util_test suite, so I am reverting it.

Comment by Githook User [ 07/Aug/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-49371 Fix a signed/unsigned comparison compile error
Branch: master
https://github.com/mongodb/mongo/commit/72d104ca45461075fc7a4deb11d3522ff24c62f6

Comment by Githook User [ 07/Aug/20 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-49371 Revived original recursive ICE and applied to stack overflow tests
Branch: master
https://github.com/mongodb/mongo/commit/77ce2860da66ab9924c0668c76fae564eb7c7dfc

Comment by Andrew Morrow (Inactive) [ 14/Jul/20 ]

ben.caimano and reo.kimura - This is one of the remaining two TSAN failures blocking the unit tests from being green (the other being SERVER-49030). The SDP team would appreciate it if the SA team would make this a priority on the next BF day for the team.

Generated at Thu Feb 08 05:19:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.