[SERVER-49391] Run ephemeralForTest/biggie suites with --enableMajorityReadConcern=0 Created: 09/Jul/20 Updated: 13/Aug/20 Resolved: 13/Aug/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication, Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Pulo | Assignee: | Henrik Edin |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Sprint: | Execution Team 2020-07-27, Execution Team 2020-08-24 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 25 | ||||||||||||||||
| Description |
|
The enableMajorityReadConcern server parameter defaults to true, even when using a storage engine where supportsReadConcernMajority() is false. This means that the tests in the ephemeralForTest and biggie suites are not exercising the correct code, because enableMajorityReadConcern is checked throughout the codebase. This ticket is to adjust the evergreen.yml to add the resmoke --majorityReadConcern=off flag to these suites. |
| Comments |
| Comment by Gregory Wlodarek [ 13/Aug/20 ] |
|
We're going to have to do this work in |
| Comment by Henrik Edin [ 20/Jul/20 ] |
|
Setting this requires getTimestampReadSource() to be implemented for the storage engine. See: https://github.com/mongodb/mongo/blob/ab1a892520e9a9b84ae90d52f84a0f107efbdecd/src/mongo/db/read_concern_mongod.cpp#L497-L500 |