[SERVER-49392] Make storage engine init check that enableMajorityReadConcern is compatible with supportsReadConcernMajority Created: 09/Jul/20  Updated: 29/Oct/23  Resolved: 17/Aug/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Kevin Pulo Assignee: Gregory Wlodarek
Resolution: Fixed Votes: 0
Labels: thread-sanitizer
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-50280 Remove 'startSetIfSupportsReadMajorit... Closed
Documented
is documented by DOCS-13838 Investigate changes in SERVER-49392: ... Closed
Duplicate
is duplicated by SERVER-49391 Run ephemeralForTest/biggie suites wi... Closed
Related
Backwards Compatibility: Minor Change
Sprint: Execution Team 2020-08-24
Participants:
Linked BF Score: 25

 Description   

The enableMajorityReadConcern server parameter defaults to true, even when using a storage engine where supportsReadConcernMajority() is false. Ideally it should default to false in such cases, however, implementing this is probably more effort than it's worth (it only affects test storage engines). Instead, storage engine creation/init should check if supportsReadConcernMajority is false and enableMajorityReadConcern is true, and handle it accordingly: either force enableMajorityReadConcern to false (if it isn't too late to do that), or else abort startup with an error message (saying that this combination isn't valid and enableMajorityReadConcern must be disabled to run with this storage engine).



 Comments   
Comment by Githook User [ 18/Aug/20 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-49392 Fix the TSAN builder by disabling majority read concern as it's using ephemeralForTest
Branch: master
https://github.com/mongodb/mongo/commit/a492cd866197ce111844c5e8ae6639e5ca0b8c5b

Comment by Githook User [ 17/Aug/20 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-49392 Storage engine init checks that enableMajorityReadConcern is compatible with supportsReadConcernMajority()
Branch: master
https://github.com/mongodb/mongo/commit/56b83070a83b2bf134a54063b27c2b48b22dd852

Generated at Thu Feb 08 05:19:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.