[SERVER-49392] Make storage engine init check that enableMajorityReadConcern is compatible with supportsReadConcernMajority Created: 09/Jul/20 Updated: 29/Oct/23 Resolved: 17/Aug/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Pulo | Assignee: | Gregory Wlodarek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | thread-sanitizer | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||||||||||||||
| Sprint: | Execution Team 2020-08-24 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 25 | ||||||||||||||||||||||||||||
| Description |
|
The enableMajorityReadConcern server parameter defaults to true, even when using a storage engine where supportsReadConcernMajority() is false. Ideally it should default to false in such cases, however, implementing this is probably more effort than it's worth (it only affects test storage engines). Instead, storage engine creation/init should check if supportsReadConcernMajority is false and enableMajorityReadConcern is true, and handle it accordingly: either force enableMajorityReadConcern to false (if it isn't too late to do that), or else abort startup with an error message (saying that this combination isn't valid and enableMajorityReadConcern must be disabled to run with this storage engine). |
| Comments |
| Comment by Githook User [ 18/Aug/20 ] |
|
Author: {'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}Message: |
| Comment by Githook User [ 17/Aug/20 ] |
|
Author: {'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}Message: |